[release/9.0-staging] Add a missing = in BigInteger.cs #109732
+272
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…eneration.cs Co-authored-by: Dan Moseley <danmose@microsoft.com>
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
tannergooding
added
the
Servicing-consider
|
CC. @jeffhandley |
jeffhandley
approved these changes
Nov 12, 2024
|
Added the additional regression test from the other community PR. |
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
|
Tagging @artl93 for awareness |
artl93
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #105456 to release/9.0-staging
/cc @tannergooding @LEI-Hongfaan
Customer Impact
Reported by a customer in #109669. BigInteger may compute an incorrect result when the value produced is a value of the form
-(2^(32 * n))wheren >= 1. This is primarily prevalent to bitwise operations such as&(and),|(or), and^(xor).Regression
This is a regression from .NET 8.
Testing
Additional tests covering the edge case were added. The failure was due to a comparison doing
>(greater than) rather than>=(greater than or equal to) as the equals sign was accidentally dropped in a refactoring.Risk
Low.
This fix is itself low risk, resolves the issue, and is understood why it is the correct solution.