Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging internal commits for release/8.0 #109742

Conversation

vseanreesermsft
Copy link

No description provided.

rzikm and others added 11 commits August 28, 2024 16:05
Port of https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/pullrequest/42181 for 8.0

# Description

Use explicit full-path for loading MsQuic.dll - it prevents accidental load of MsQuic.dll from another unintended directory (e.g. CWD = Current Working Directory) if the bundled MsQuic.dll fails to load (which can happen e.g. on WinServer 2012, where MsQuic is not supported).

# Customer Impact

Defense-in-depth

# Regression

No

# Testing

Targeted manual test on affected OS (Windows Server 2012), including self-contained and single-file publish scenarios.

# Risk

Low, changes are contained and have been thoroughly tested manually and in CI suite.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis teo-tsirpanis added area-codeflow for labeling automated codeflow and removed area-System.Net labels Nov 12, 2024
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Dec 2, 2024
@carlossanlop carlossanlop merged commit 2eb7dd0 into dotnet:release/8.0 Dec 2, 2024
109 of 112 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants