Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for [UnsafeAccessor] on fields with readonly #109944

Conversation

Sergio0694
Copy link
Contributor

@Sergio0694 Sergio0694 commented Nov 19, 2024

Closes #109943

Follow up to #109694, adds some tests to cover #109943 too, just in case.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 19, 2024
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cae0e0f into dotnet:main Nov 19, 2024
70 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/readonly-accessor-tests branch November 19, 2024 06:05
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.CompilerServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UnsafeAccessor] throws MissingFieldException on .NET 9 when used on unspeakable fields
2 participants