-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ppc64le] Fixed System.Runtime.Intrinsics tests failures #110126
Open
alhad-deshpande
wants to merge
34
commits into
dotnet:release/9.0
Choose a base branch
from
Sapana-Khemkar:ppc64le_binaryformatter_tensors_tests_fix
base: release/9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ppc64le] Fixed System.Runtime.Intrinsics tests failures #110126
alhad-deshpande
wants to merge
34
commits into
dotnet:release/9.0
from
Sapana-Khemkar:ppc64le_binaryformatter_tensors_tests_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l method for ppc64le architecture
…ime.Serialization.Formatters.Tests
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Nov 25, 2024
Tagging subscribers to this area: @steveisok, @vitek-karas |
This was referenced Nov 25, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Codegen-JIT-mono
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed System.Runtime.Intrinsics tests failures on Power by adding support to pass parameters with larger offsets than 16K on stack. This is a bacport PR of #109725 for .NET 9.0 release branch.
Business Justifcation: The fix is in a power specific file and does not pose any risk to other architectures. As the fix is related to passing the parameters on stack with larger offsets, this is a very important fix that must go in .NET 9. Without this fix, users on Power might get into this error if there is larger stack size which can be due to heavy inlining of functions.
Cc: @leecow @uweigand @janani66