Delete shared ThrowHelper used only a single test #110313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
If ThrowHelper.IfNullOrWhitespace were not deleted, I think it should have a comment added to warn against using it in non-test code because its exception message is not localized. |
But it is :-) |
Thus the irrealis mood :-) |
MihaZupan
approved these changes
Dec 2, 2024
jkotas
approved these changes
Dec 2, 2024
|
/ba-g unrelated failures |
|
@stephentoub I’m grateful for the opportunity to contribute by filing this issue and truly appreciate that you personally addressed it. I have always respected your work and contributions to .NET. This is also my first time filing an issue in the runtime that gets a fix. |
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this pull request
Dec 5, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110294