[cdac] Fix calculation of MethodDesc optional slot addresses
#110491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escOptionalSlots helper
elinor-fung
requested review from
davidwrighton,
AaronRobinsonMSFT and
max-charlamb
11 tasks
|
Tagging subscribers to this area: @tommcdon |
This was referenced Dec 7, 2024
AaronRobinsonMSFT
approved these changes
Dec 9, 2024
This was referenced Dec 10, 2024
Open
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…t#110491) The cDAC was assuming that the additional data after a MethodDesc were each just pointers. That is only true for the non-vtable slot and native code slot, not method impl. This change includes the size of those additional slots in the data descriptor and uses them when computing the addresses those optional slots. As part of this, I pulled out shared helpers around dealing with optional slots for use by `MethodValidation` and `RuntimeTypeSystem_1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cDAC was assuming that the additional data after a MethodDesc were each just pointers. That is only true for the non-vtable slot and native code slot, not method impl. This change includes the size of those additional slots in the data descriptor and uses them when computing the addresses those optional slots.
As part of this, I pulled out shared helpers around dealing with optional slots for use by
MethodValidationandRuntimeTypeSystem_1.Found this while trying to finish out
RuntimeTypeSystem_1.GetMethodClassificationDataTypefor #109426 when doing a!dumpmtfor a method table with explicit interface implementations (or!dumpmdon a method that is an explicit interface implementation).Contributes to #99302, #109426