JIT: Fix reporting of tier name metadata #110610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tier name was reported for both the root and the inlinees. On the SPMI side this would result in using the last tier name reported, which usually would be from an inlinee. The inlinee tier does not always match the root tier, for example when OSR is enabled.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
commented
Dec 11, 2024
Comment on lines
+160
to
167
| fw.PrintQuotedCsvField(diffRes.CompileResults->MethodFullName == nullptr ? "" : diffRes.CompileResults->MethodFullName); | ||
| fw.Printf( | ||
| ",%s,%s,%s,%s,%s,%lld,%lld", | ||
| baseRes.CompileResults->TieringName == nullptr ? "" : baseRes.CompileResults->TieringName, | ||
| diffRes.CompileResults->TieringName == nullptr ? "" : diffRes.CompileResults->TieringName, | ||
| ResultToString(baseRes.Result), ResultToString(diffRes.Result), | ||
| baseRes.IsMinOpts ? "True" : "False", | ||
| diffRes.IsMinOpts ? "True" : "False", | ||
| hasDiff ? "True" : "False", | ||
| baseRes.NumExecutedInstructions, diffRes.NumExecutedInstructions); |
There was a problem hiding this comment.
Somewhat unrelated change, but I was a bit confused for a while when my change did not have any effect on my asmdiffs details. Turned out to be because the base JIT continued to contain the bug.
|
/azp run runtime-coreclr superpmi-replay, runtime-coreclr superpmi-diffs |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Dec 12, 2024
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
The tier name was reported for both the root and the inlinees. On the SPMI side this would result in using the last tier name reported, which usually would be from an inlinee. The inlinee tier does not always match the root tier, for example when OSR is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tier name was reported for both the root and the inlinees. On the SPMI side this would result in using the last tier name reported, which usually would be from an inlinee. The inlinee tier does not always match the root tier, for example when OSR is enabled.