Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CFG-enabled VxSortDisabled flavor of runtime libs #110613

Closed
wants to merge 1 commit into from

Conversation

MichalStrehovsky
Copy link
Member

I haven't done this originally but CFG enabled is starting to be popular and this is an easy 100 kB saving.

We could also build a server GC less flavor of the runtime (another 250 kB saving), but that slows down the build by several seconds so not sure if we want that tradeoff for dev innerloop.

Cc @dotnet/ilc-contrib

I haven't done this originally but CFG enabled is starting to be popular and this is an easy 100 kB saving.

We could also build a server GC less flavor of the runtime (another 250 kB saving), but that slows down the build by several seconds so not sure if we want that tradeoff for dev innerloop.
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Dec 11, 2024

We could also build a server GC less flavor of the runtime (another 250 kB saving), but that slows down the build by several seconds so not sure if we want that tradeoff for dev innerloop.

It sounds like a good idea to me. If the few seconds are important for dev innerloop, we can place all CFG enabled libs into a subset that builds in the full build only.

Alternatively, it may be interesting to measure benefits that we get from building CFG enabled/disabled flavors. It may be ok to use CFG enabled build of the runtime even when the CFG is disabled for the project. We are on this plan for zlib, brotli, minipal and libraries shims already.

@MichalStrehovsky
Copy link
Member Author

Alternatively, it may be interesting to measure benefits that we get from building CFG enabled/disabled flavors. It may be ok to use CFG enabled build of the runtime even when the CFG is disabled for the project. We are on this plan for zlib, brotli, minipal and libraries shims already.

That's even better. Closing this in favor of #110671.

@MichalStrehovsky MichalStrehovsky deleted the vxdisablecfg branch December 12, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants