Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Avoid duplicate example diffs in diffs summary #110619

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

jakobbotsch
Copy link
Member

We frequently see examples like this in the diffs report produced:
image

This PR deduplicates the contexts picked by method name, ensuring that we only get one of each name. I've also improved the logic to pick example regressions to show. After:
image

cc @dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This deduplicates the examples that can be picked by their method name;
this means that the examples no longer should show multiple example
diffs with the same name.
@jakobbotsch jakobbotsch force-pushed the avoid-duplicate-example-diffs branch from 3d5ec44 to 9f87a0e Compare December 11, 2024 16:43
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing I've noticed in some diffs is that we'll only get diffs visible for the locals info dump and not actual code. It would be nice if that could also get resolved and to favor diffs that start after the first instruction group (in the actual code).

@jakobbotsch
Copy link
Member Author

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member Author

One other thing I've noticed in some diffs is that we'll only get diffs visible for the locals info dump and not actual code. It would be nice if that could also get resolved and to favor diffs that start after the first instruction group (in the actual code).

I remember @EgorBo had the same wish when I initially added the examples. One simple thing we could do is just pick the last X lines of the diff instead of the first X lines.

The only thing is that the diffs in the local vars table can actually be pretty useful when looking at the examples, to make quick determinations. For example it quickly tells me about physical promotions or if strength reduction kicked in. But it makes sense to me to prefer the codegen diffs when the diff is too large to show fully.

@jakobbotsch jakobbotsch merged commit 3eeea54 into dotnet:main Dec 12, 2024
88 checks passed
@jakobbotsch jakobbotsch deleted the avoid-duplicate-example-diffs branch December 12, 2024 12:14
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
This deduplicates the examples that can be picked by their method name;
this means that the examples no longer should show multiple example
diffs with the same name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants