-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPMI: Avoid duplicate example diffs in diffs summary #110619
SPMI: Avoid duplicate example diffs in diffs summary #110619
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This deduplicates the examples that can be picked by their method name; this means that the examples no longer should show multiple example diffs with the same name.
3d5ec44
to
9f87a0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing I've noticed in some diffs is that we'll only get diffs visible for the locals info
dump and not actual code. It would be nice if that could also get resolved and to favor diffs that start after the first instruction group (in the actual code).
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
I remember @EgorBo had the same wish when I initially added the examples. One simple thing we could do is just pick the last X lines of the diff instead of the first X lines. The only thing is that the diffs in the local vars table can actually be pretty useful when looking at the examples, to make quick determinations. For example it quickly tells me about physical promotions or if strength reduction kicked in. But it makes sense to me to prefer the codegen diffs when the diff is too large to show fully. |
This deduplicates the examples that can be picked by their method name; this means that the examples no longer should show multiple example diffs with the same name.
We frequently see examples like this in the diffs report produced:
This PR deduplicates the contexts picked by method name, ensuring that we only get one of each name. I've also improved the logic to pick example regressions to show. After:
cc @dotnet/jit-contrib