[cdac] Clear cached data as part of IXCLRDataProcess::Flush #110700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
max-charlamb
approved these changes
Dec 13, 2024
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…10700) Found this while running the diagnostics repo SOS tests with the cDAC enabled. General sequence for the repro was: ``` !sethostruntime -none !bpmd <firstLocation> !bpmd <secondLocation> g g !clrstack ``` Printed stack shows `<unknown>` for some method(s). Between the first and second breakpoints, more methods were jitted and the corresponding code heap list updated. When a new method in the stack for `<secondLocation>` had the same code heap list as any method from `<firstLocation>`, we'd end up with a stale end address for the heap list and determine that the method was invalid (outside the address range). The cdac was assuming that the target would be created every time the state changes, but that is not the case (for the repro above, `!sethostruntime -none` resulted in not re-creating the target). We need to handle `IXCLRDataProcess::Flush` calls to clear out any cached data. With this change, the SOS tests with the cDAC enabled run successfully with both a Release and Debug cdacreader (on a Release runtime).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while running the diagnostics repo SOS tests with the cDAC enabled. General sequence for the repro was:
Printed stack shows
<unknown>for some method(s).Between the first and second breakpoints, more methods were jitted and the corresponding code heap list updated. When a new method in the stack for
<secondLocation>had the same code heap list as any method from<firstLocation>, we'd end up with a stale end address for the heap list and determine that the method was invalid (outside the address range).The cdac was assuming that the target would be created every time the state changes, but that is not the case (for the repro above,
!sethostruntime -noneresulted in not re-creating the target). We need to handleIXCLRDataProcess::Flushcalls to clear out any cached data.With this change, the SOS tests with the cDAC enabled run successfully with both a Release and Debug cdacreader (on a Release runtime).
Contributes to #99302