Tests ran counter #111145
Merged
Tests ran counter #111145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/gc |
markples
reviewed
Jan 7, 2025
| @@ -22,6 +22,7 @@ | |||
| using System.Linq; | |||
|
|
|||
| using System.Runtime.Loader; | |||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | |||
There was a problem hiding this comment.
I don't think this is needed
markples
reviewed
Jan 7, 2025
| public void RecordTestRanCount() | ||
| { | ||
| StringBuilder sb = new(); | ||
| foreach(var item in _testRanCounter) |
There was a problem hiding this comment.
When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.
markples
reviewed
Jan 7, 2025
Comment on lines
1226
to
1230
| if (!_testRanCounter.Keys.Contains(testRefOrID)) | ||
| { | ||
| _testRanCounter[testRefOrID] = 0; | ||
| } | ||
| _testRanCounter[testRefOrID] ++; |
There was a problem hiding this comment.
(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)
mrsharm
reviewed
Jan 8, 2025
| sb.AppendLine($"{item.Key}: {item.Value}"); | ||
| } | ||
| } | ||
| _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}"); |
mrsharm
reviewed
Jan 8, 2025
| @@ -161,6 +163,11 @@ public static int Main(string[] args) | |||
|
|
|||
| ReliabilityFramework rf = new ReliabilityFramework(); | |||
| rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started"); | |||
|
|
|||
| Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => { | |||
There was a problem hiding this comment.
NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }
mrsharm
reviewed
Jan 8, 2025
| @@ -314,6 +321,19 @@ public static int Main(string[] args) | |||
| return (retVal); | |||
| } | |||
|
|
|||
| public void RecordTestRanCount() | |||
There was a problem hiding this comment.
NIT: The name RecordTestRunCount seems more apt.
3 tasks
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 4, 2025
* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record how many times each test ran for. (even if the run is terminated manually)