Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Bump chrome for testing - linux: 132.0.6834.83, windows: 132.0.6834.84 #111580

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 19, 2025

Playwright on passing Headless: true uses the headless=old flag that is not supported in v>128. We can pass the flag on our own, both headless=new (only for v>128) and headless (all versions) work.

Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member

lewing commented Jan 21, 2025

 <launched> pid=951
        - [pid=951][err] Old Headless mode has been removed from the Chrome binary. Please use the new Headless mode (https://developer.chrome.com/docs/chromium/new-headless) or the chrome-headless-shell which is a standalone implementation of the old Headless mode (https://developer.chrome.com/blog/chrome-headless-shell).
        - [pid=951][err] 
      Stack Trace:
        /_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
        /_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
        /_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
        /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String locale)
        /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(165,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String locale, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(304,0): at Wasm.Build.Tests.WasmTemplateTestsBase.BrowserRunTest(String runArgs, String workingDirectory, RunOptions runOptions)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(329,0): at Wasm.Build.Tests.WasmTemplateTestsBase.BrowserRunTest(String runArgs, String workingDirectory, RunOptions runOptions)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(260,0): at Wasm.Build.Tests.WasmTemplateTestsBase.BrowserRun(RunOptions runOptions)
        /_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs(255,0): at Wasm.Build.Tests.WasmTemplateTestsBase.RunForBuildWithDotnetRun(RunOptions runOptions)
        /_/src/mono/wasm/Wasm.Build.Tests/LazyLoadingTests.cs(42,0): at Wasm.Build.Tests.LazyLoadingTests.LoadLazyAssemblyBeforeItIsNeeded(String lazyLoadingTestExtension, String[] allLazyLoadingTestExtensions)

@ilonatommy ilonatommy self-assigned this Jan 22, 2025
@ilonatommy
Copy link
Member

ilonatommy commented Jan 22, 2025

Playwright does not support the new headless mode out of the box if we are using a custom path to the browser doc.

The best fix is to update the urls that we are pulling chrome from to match the new chrome-headless-shell releases.

Edit: for chromium that we're using in tests, shell version is not shipped. Instead, we should use headless=new or headless.

@ilonatommy
Copy link
Member

Performance failures are not related. Checked on a playground PR: #111747.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ilonatommy
Copy link
Member

/ba-g failures are not related

@ilonatommy ilonatommy merged commit 85506c3 into main Jan 24, 2025
32 of 38 checks passed
@jkotas jkotas deleted the update-chrome-version-12848518924 branch February 2, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants