fix the regression in regions when handling heavily pinning scenarios #112403
+230
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
mrsharm
reviewed
Feb 11, 2025
| @@ -3376,61 +3374,61 @@ gc_heap::dt_low_ephemeral_space_p (gc_tuning_point tp) | |||
|
|
|||
| BOOL | |||
| gc_heap::dt_high_frag_p (gc_tuning_point tp, | |||
| int gen_number, | |||
| BOOL elevate_p) | |||
| int gen_number, | |||
There was a problem hiding this comment.
NIT: Looks like the indentation changed here.
mrsharm
reviewed
Feb 11, 2025
| { | ||
| size_t maxgen_size = generation_size (max_generation); | ||
| float frag_ratio = (maxgen_size ? ((float)dd_fragmentation (dynamic_data_of (max_generation)) / (float)maxgen_size) : 0.0f); | ||
| if (frag_ratio > 0.65) |
There was a problem hiding this comment.
Worth creating a global const variable for the 0.65?
mrsharm
reviewed
Feb 11, 2025
| { | ||
| dynamic_data* dd = dynamic_data_of (gen_number); | ||
| float fragmentation_burden = 0; | ||
| case tuning_deciding_condemned_gen: |
There was a problem hiding this comment.
NIT: Indentation seems to be affected here, as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will add description soon.