Split FormatBigInteger
into smaller parts.
#112413
Open
+33
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fix #111708
After investigating the unexpected behavior in #111708, I concluded that JIT optimization is not functioning properly.
By splitting the part of
FormatBigInteger
that converts bits into base 1,000,000,000 into separate methods, I hope to improve JIT optimization.This pull request conflicts with my pull request #112178, but I created this as I expect this PR to be backported to .NET 9.
Benchmark
In benchmarks using the released
System.Runtime.Numerics.dll
, it is about twice as slow compared to \main\corerun.exe.Code