Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coreclr release build on windows to not use unknown switch #128

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix coreclr release build on windows to not use unknown switch #128

merged 1 commit into from
Nov 19, 2019

Conversation

safern
Copy link
Member

@safern safern commented Nov 19, 2019

if you currently try and build coreclr subset in windows with -configuration Release it fails because tries to pass down the -stripsymbols switch which only exists for Unix.

MSBUILD : error MSB1001: Unknown switch. [E:\repos\runtime\src\coreclr\coreclr.proj]
  Switch: -stripsymbols

  For switch syntax, type "MSBuild -help"
  Build failed.
BUILD : error : Failed to generate version headers. [E:\repos\runtime\src\coreclr\coreclr.proj]
E:\repos\runtime\src\coreclr\coreclr.proj(21,5): error MSB3073: The command ""E:\repos\runtime\src\coreclr\build.cmd" -skiptests -x64 -release -enforcepgo -stripsymbols -officialbuildid=" exited with code 1.

Build FAILED.

FYI: @tarekgh (thanks for reporting the issue)

@safern safern merged commit 4f58e47 into dotnet:master Nov 19, 2019
@safern safern deleted the FixCoreclrReleaseWindows branch November 19, 2019 21:10
ViktorHofer
ViktorHofer reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Oct 12, 2020
@MichalStrehovsky
Add pipeline to run Pri-0 CoreCLR tests (dotnet#128)
7c2a5b9
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@safern @jkoritzinsky @ViktorHofer @tarekgh @karelz @Dotnet-GitSync-Bot