Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with SqlCommandSet not working with Byte Array parameters #1462

Closed
wants to merge 6 commits into from
Closed

Fix issues with SqlCommandSet not working with Byte Array parameters #1462

wants to merge 6 commits into from

Conversation

cheenamalhotra
Copy link
Member

Ports fix to System.Data.SqlClient from dotnet/SqlClient#360.
Tests not added as Microsoft.Data.SqlClient tests are now covering this scenario.

@stephentoub
Copy link
Member

Tests not added as Microsoft.Data.SqlClient tests are now covering this scenario.

We still need tests for System.Data.SqlClient. It is a separate library shipped in a separate distribution.

@cheenamalhotra
Copy link
Member Author

We still need tests for System.Data.SqlClient. It is a separate library shipped in a separate distribution.

Done!

@jkotas
Copy link
Member

jkotas commented Feb 4, 2020

The System.Data.SqlClient package is being deleted from master by #2275 . If you believe that this is important bug to warrant servicing fix, it should go to https://github.com/dotnet/corefx/tree/release/3.1 .

@jkotas jkotas closed this Feb 4, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants