Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotate System.IO.Pipes #31918

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Nullable annotate System.IO.Pipes #31918

merged 2 commits into from
Feb 10, 2020

Conversation

eiriktsarpalis
Copy link
Member

Contributes to #2339

@eiriktsarpalis eiriktsarpalis changed the title Annotate System.IO.Pipes Nullable annotate System.IO.Pipes Feb 7, 2020
stephentoub
stephentoub approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments to be addressed, LGTM.

@eiriktsarpalis eiriktsarpalis merged commit 02ea20a into dotnet:master Feb 10, 2020
@eiriktsarpalis eiriktsarpalis deleted the annotate-system-io-pipes branch February 10, 2020 16:30
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@safern safern Awaiting requested review from safern

@buyaa-n buyaa-n Awaiting requested review from buyaa-n

Assignees
No one assigned
Labels
area-System.IO new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eiriktsarpalis @stephentoub @maryamariyan @Dotnet-GitSync-Bot