Add Socket.OSSupportsUnixDomainSocket #32160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failures seem related. |
stephentoub
force-pushed
the
socketsunix
branch
from
a04eeb0
to
666f321
Compare
jkotas
reviewed
Feb 12, 2020
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UnixDomainSocketEndPoint.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Feb 12, 2020
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
socketsunix
branch
from
666f321
to
7554680
Compare
jkotas
approved these changes
Feb 12, 2020
lpereira
reviewed
Feb 12, 2020
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.Unix.cs
Outdated
Show resolved
Hide resolved
lpereira
reviewed
Feb 12, 2020
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.Windows.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Feb 12, 2020
src/libraries/Common/src/System/Net/SocketProtocolSupportPal.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
socketsunix
branch
2 times, most recently
from
1f316ce
to
777fd7e
Compare
davidsh
approved these changes
Feb 12, 2020
stephentoub
force-pushed
the
socketsunix
branch
2 times, most recently
from
9b0bd03
to
ac84c17
Compare
stephentoub
force-pushed
the
socketsunix
branch
from
ac84c17
to
7218f62
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #863
cc: @dotnet/ncl
I also noticed that a) we had non-trivial duplication of code between a .Windows.cs and .Unix.cs file, and b) we were using 0 as INVALID_SOCKET when it's actually -1. I fixed both.