Added specification for field handling #32711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
reviewed
Feb 28, 2020
There was a problem hiding this comment.
Please add notes addressing crucial questions for this feature highlighted in #2192 (comment):
- Which of the existing property-level attributes should be applied to fields? Should
JsonExtensionDataapply to fields? - Which of the options in
JsonSerializerOptionsshould apply to fields? ShouldPropertyNamingPolicy,PropertyNameCaseInsensitiveapply to fields, or do we need new options? - Should
readonlyfields be supported for deserialization? Should there be an option to ignorereadonlyfields for serialization (an equivalent toIgnoreReadOnlyProperties)?
Everything that comment should be included in this spec, at least as an open question.
|
Thanks, @YohDeadfall. I've added the API proposal for this feature - #34558. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening it as work in progress since there should some work be done and the right decision taken about how fields should be handled. After this gets merged I will continue my work on #2192.