Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing IAsyncDisposable interfaces to System.Data.Common #33265

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add missing IAsyncDisposable interfaces to System.Data.Common #33265

merged 1 commit into from
Mar 6, 2020

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Mar 5, 2020

Port of dotnet/corefx#40872 to dotnet/runtime

stephentoub
stephentoub approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@ericstj
Copy link
Member Author

ericstj commented Mar 6, 2020

Failures: #32764 x2 and DownloadBuildArtifacts truncating a download.

@ericstj ericstj merged commit d931095 into dotnet:master Mar 6, 2020
@jaredpar jaredpar mentioned this pull request Mar 6, 2020
Closed
@roji
Copy link
Member

roji commented Mar 6, 2020

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@stephentoub stephentoub stephentoub approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@roji roji Awaiting requested review from roji

Assignees
No one assigned
Labels
area-System.Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericstj @roji @stephentoub @cheenamalhotra @Dotnet-GitSync-Bot