Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MemberNotNull/When attributes #33567

Merged
merged 8 commits into from
Mar 19, 2020
Merged

Add MemberNotNull/When attributes #33567

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9c7558
Add MemberNotNull/When attributes
jcouv Mar 13, 2020
0890db6
Apply [CLSCompliant(false)]
jcouv Mar 13, 2020
bcad926
Fix typos and indent
jcouv Mar 13, 2020
9c783a2
Move [CLSCompliant(false)] and remove AllowMultiple
jcouv Mar 13, 2020
c12885d
Declare attributes in ref file
jcouv Mar 13, 2020
e3fd12e
Store parameters into readonly properties
jcouv Mar 13, 2020
e644186
Don't use deconstruction
jcouv Mar 13, 2020
7e4a725
Qualify, move properties, remove this
jcouv Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ...ibraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/NullableAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,41 @@ sealed class DoesNotReturnIfAttribute : Attribute
/// <summary>Gets the condition parameter value.</summary>
public bool ParameterValue { get; }
}

/// <summary>Sepcifies that the method or property will ensure that the listed field and property members have not-null values.</summary>
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property, AllowMultiple = false, Inherited = false)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllowMultiple = false is the default and so doesn't need to be specified. Same below.

[CLSCompliant(false)]
#if INTERNAL_NULLABLE_ATTRIBUTES
internal
#else
public
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
#endif
sealed class MemberNotNullAttribute : Attribute
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
{
/// <summary>Initializes the attribute with the list of field and property members.</summary>
/// <param name="members">
/// The list of field and property members that are promised to be not-null.
/// </param>
public MemberNotNullAttribute(params string[] members) { }
}

/// <summary>Sepcifies that the method or property will ensure that the listed field and property members have not-null values when returning with the specified return value condition.</summary>
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property, AllowMultiple = false, Inherited = false)]
[CLSCompliant(false)]
#if INTERNAL_NULLABLE_ATTRIBUTES
internal
#else
public
#endif
sealed class MemberNotNullWhenAttribute : Attribute
{
/// <summary>Initializes the attribute with the specified return value condition and list of field and property members.</summary>
/// <param name="returnValue">
/// The return value condition. If the method returns this value, the associated parameter will not be null.
/// </param>
/// <param name="members">
/// The list of field and property members that are promised to be not-null.
/// </param>
public MemberNotNullWhenAttribute(bool returnValue, params string[] members) { }
}
}