Sync with ASP.NET Core dynamic HPack changes #34247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
reviewed
Mar 29, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/StatusCodes.cs
Outdated
Show resolved
Hide resolved
lpereira
reviewed
Mar 30, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/HPackEncoder.Dynamic.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 31, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/HPackEncoder.Dynamic.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 31, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/HPackEncoder.Dynamic.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 31, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/HPackEncoder.Dynamic.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 31, 2020
src/libraries/Common/src/System/Net/Http/aspnetcore/Http2/Hpack/HPackEncoder.Dynamic.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/hpack-dynamic-compression
branch
from
d031080
to
2d8d291
Compare
JamesNK
changed the title
Tratcher
approved these changes
Apr 2, 2020
|
Fixes dotnet/aspnetcore#18943 |
|
@JamesNK for future reference, try to merge the runtime and aspnetcore changes in the same day so everything stays in sync. |
|
I don’t have permission. One of you all will need to click the button. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shareable logic from adding dynamic hpack compression to ASP.NET Core - dotnet/aspnetcore#20058As requested the HPack dynamic logic has been moved out of shared code until System.Net.Http wants to use it. The sync changes now just make some types partial and encoding helpers.