-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WASM image #34421
Update WASM image #34421
Conversation
Move to an Ubuntu image which has the `en_US.UTF-8` locale available. This should remove the spurious warning that we're seeing during PR / CI closes dotnet#34280
Once merged builds should be completely warning free. |
The libraries failure was a Helix 503, re-running. |
Thanks @jaredpar. Since we're now warnings free, in order to prevent introducing new warnings, could you also remove: |
I will definitely do that but prefer to do as a separate PR. Given the last time I tried that I broke the outer loop wanted to have a PR where I just changed that, queued up a coulpe of the outer loop jobs and ensure I didn't break them with the warn as error change (again 😦 ). |
I think for this change you should be safe as we build the same configurations and same containers for outerloop jobs, but since you're making the change, I'll leave it up to you. |
Move to an Ubuntu image which has the
en_US.UTF-8
locale available.This should remove the spurious warning that we're seeing during
PR / CI
closes #34280