Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WASM image #34421

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Update WASM image #34421

merged 1 commit into from
Apr 2, 2020

Conversation

jaredpar
Copy link
Member

@jaredpar jaredpar commented Apr 1, 2020

Move to an Ubuntu image which has the en_US.UTF-8 locale available.
This should remove the spurious warning that we're seeing during
PR / CI

closes #34280

Move to an Ubuntu image which has the `en_US.UTF-8` locale available.
This should remove the spurious warning that we're seeing during
PR / CI

closes dotnet#34280
@jaredpar jaredpar marked this pull request as ready for review April 1, 2020 22:31
@jaredpar
Copy link
Member Author

jaredpar commented Apr 1, 2020

Once merged builds should be completely warning free.

@jaredpar
Copy link
Member Author

jaredpar commented Apr 1, 2020

@jaredpar
Copy link
Member Author

jaredpar commented Apr 1, 2020

The libraries failure was a Helix 503, re-running.

@safern
Copy link
Member

safern commented Apr 2, 2020

Thanks @jaredpar. Since we're now warnings free, in order to prevent introducing new warnings, could you also remove: _warnAsErrorArg and all it's references from: https://github.com/dotnet/runtime/blob/5369c7119b0f174c2614fe4ee197bdb0c42010a1/eng/pipelines/libraries/base-job.yml as part of this change?

@jaredpar
Copy link
Member Author

jaredpar commented Apr 2, 2020

Since we're now warnings free, in order to prevent introducing new warnings, could you also remove: _warnAsErrorArg and all it's references from:

I will definitely do that but prefer to do as a separate PR. Given the last time I tried that I broke the outer loop wanted to have a PR where I just changed that, queued up a coulpe of the outer loop jobs and ensure I didn't break them with the warn as error change (again 😦 ).

@safern
Copy link
Member

safern commented Apr 2, 2020

I think for this change you should be safe as we build the same configurations and same containers for outerloop jobs, but since you're making the change, I'll leave it up to you.

@jaredpar jaredpar merged commit 7dab162 into dotnet:master Apr 2, 2020
@jaredpar jaredpar deleted the warn branch April 2, 2020 13:44
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LC_ALL warning during CI / PR builds
5 participants