Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable Proxy_UseEnvironmentVariableToSetSystemProxy_RequestGoesThruProxy test #34444

Merged
merged 12 commits into from
Apr 23, 2020
Merged

enable Proxy_UseEnvironmentVariableToSetSystemProxy_RequestGoesThruProxy test #34444

merged 12 commits into from
Apr 23, 2020

Conversation

aik-jahoda
Copy link
Contributor

The test is not failing I run it in the loop. Enabling it again.

@aik-jahoda aik-jahoda mentioned this pull request Apr 2, 2020
Closed
2 tasks
stephentoub
stephentoub approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run outerloop tests. If CI is green, LGTM. Thanks.

@davidsh davidsh added this to the 5.0 milestone Apr 2, 2020
@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

The outer loop test fails:
The via: HTTP/1.1 LoopbackProxyServer header is missing.
It works properly on my local machine and not on CI. It seems the http_proxy env variable is ignored on CI machine.

I need to investigate more about what is going on.

@davidsh
Copy link
Contributor

davidsh commented Apr 7, 2020

It works properly on my local machine and not on CI. It seems the http_proxy env variable is ignored on CI machine.
I need to investigate more about what is going on.

It could be due to mitigation of https://httpoxy.org/. Typically, many CGI and other server environments explicitly filter out the 'http_proxy' environment variable. That could thus interfere with this test case.

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaredpar jaredpar mentioned this pull request Apr 14, 2020
Closed
@aik-jahoda aik-jahoda mentioned this pull request Apr 15, 2020
Closed
@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aik-jahoda
Copy link
Contributor Author

@davidsh, can you please review the final fix? The issue was that the failing test was in the WinHttpHandler test which doesn't support testing functionality.

All failing tests are failing on different tests not the test related to this PR

@jaredpar jaredpar mentioned this pull request Apr 21, 2020
Closed
@davidsh
Copy link
Contributor

davidsh commented Apr 22, 2020

@davidsh David Shulman FTE, can you please review the final fix?

Can you review my question here ?

@aik-jahoda
Copy link
Contributor Author

Thanks for the sugestion @davidsh, running the outer-loop to final verification

@aik-jahoda
Copy link
Contributor Author

/azp run runtime-libraries outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidsh
Copy link
Contributor

davidsh commented Apr 22, 2020

LGTM

@aik-jahoda aik-jahoda merged commit 33bedaf into dotnet:master Apr 23, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@davidsh davidsh davidsh approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aik-jahoda @davidsh @stephentoub @Dotnet-GitSync-Bot