-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the subset feature #34663
Redesign the subset feature #34663
Conversation
Tagging @ViktorHofer as an area owner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you!
Will this affect contributors? If so, can some of the workflow changes be shared somewhere? |
I think every rollout date is going to be reminded on the gitter channel with the changes for that rollout. |
Yes, I pinned #33821 to make sure that community members know about the planned changes as well which also list the impact and the new workflow. In addition to that after this is merged I'll notify the gitter channel. The docs will be updated as part of this PR as well. Anything you are missing here? |
Changed with dotnet/runtime#34663
I guess eyes. Apologies for missing that (or perhaps I saw it and forgot about it, that sounds like something I'd do, too). |
We are doing this the first time (batched rollout + announcements) so there's definitely room for improvement. FWIW I just posted a little announcement in the gitter channel. |
Implement proposal from dotnet#34403. Remove subsetcategory and allow all subsets to specified via the -subset switch.
Merging as CI seems to be busted and I verified the changes with the existing legs. |
@ViktorHofer I think this is a nice improvement. 👍 It seems the
Is this due to a parsing limitation in the script? nit: the documentation mixes use of |
cc @safern for question above as @ViktorHofer is out rest of week. |
Right now it needs to be passed only for bash. I'm working on fixing that -- but yeah initially was because of a limitation in the script. |
Fixes #34403
Part of yesterday's batched rollout: #33821. I'll send out a mail to the team for the updated workflow instructions.