Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override IsByRefLike on S.R.E.*Builder classes #34846

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Override IsByRefLike on S.R.E.*Builder classes #34846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87e4fd2
Override IsByRefLike on S.R.E.*Builder classes
marcusturewicz Apr 11, 2020
ae27e0d
Adds tests
marcusturewicz Apr 13, 2020
66cc65e
Update System.Reflection.Emit.Tests.csproj
marcusturewicz Apr 13, 2020
b56bd56
Bumping CI
marcusturewicz Apr 16, 2020
f6723a9
Update mono as well
marcusturewicz Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/EnumBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ public FieldBuilder DefineLiteral(string literalName, object? literalValue)

public override Type? BaseType => m_typeBuilder.BaseType;

public override bool IsByRefLike => false;
marcusturewicz marked this conversation as resolved.
Show resolved Hide resolved

protected override ConstructorInfo? GetConstructorImpl(BindingFlags bindingAttr, Binder? binder,
CallingConventions callConvention, Type[] types, ParameterModifier[]? modifiers)
{
Expand Down
2 changes: 2 additions & 0 deletions ...eclr/src/System.Private.CoreLib/src/System/Reflection/Emit/GenericTypeParameterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public override bool Equals(object? o)

public override Module Module => m_type.Module;

public override bool IsByRefLike => false;

internal int MetadataTokenInternal => m_type.MetadataTokenInternal;
#endregion

Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,8 @@ public override string ToString()

public override Module Module => GetModuleBuilder();

public override bool IsByRefLike => false;

internal int MetadataTokenInternal => m_tdType.Token;

#endregion
Expand Down