Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use socketpair to implement Process.Start redirection #34861

Merged
merged 2 commits into from
May 22, 2020
Merged

Use socketpair to implement Process.Start redirection #34861

merged 2 commits into from
May 22, 2020

Commits on May 21, 2020

  1. Use socketpair to implement Process.Start redirection 

    Today on Unix, we create an anonymous pipe via pipe/pipe2 to be used for stdin/stdout/stderr on processes created by Process.Start.  We then wrap the resulting file descriptors with FileStreams to hand out via Process.StandardInput/Output/Error.  This has a few issues, however. Any async operations on the resulting stream (or wrapping stream reader) will actually be async-over-sync, and that in turn means that a) any async read will end up blocking a thread pool thread until it's satisified, and b) the operation isn't cancelable.  The implications of (b) are obvious, and the problem with (a) is that code which launches a bunch of processes and uses BeginOutput/ErrorReadLine or the like will end up blocking a bunch of thread pool threads.

This change replaces the pipe/pipe2 calls with socketpair calls, and instead of wrapping the resulting file descriptors with FileStream, wraps them in Sockets and NetworkStreams.  This gives us the full capabilities of the networking stack, which fully supports asynchronous and cancelable reads and writes.
    @stephentoub
    stephentoub committed May 21, 2020
    Configuration menu
    Copy the full SHA
    cf4adfa View commit details
    Browse the repository at this point in the history

  2. Try to fix macOS failures with socketpair

    @stephentoub
    stephentoub committed May 21, 2020
    Configuration menu
    Copy the full SHA
    e310178 View commit details
    Browse the repository at this point in the history