Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issues.targets to baseline recent Crossgen2 bugs #34917

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Apr 13, 2020

I have not yet managed to receive Windows results as the pipeline keeps timing out. I have bumped the timeout from 150 to 200 minutes in the latest commit. Linux / OSX results are however clean with my latest change. I have deleted the exclusion for BinderTracingTest.Basic as Simon is already reviewing a fix for this particular bug.

Thanks

Tomas

@trylek trylek changed the title WIP: Update issues.targets to baseline recent Crossgen2 bugs Update issues.targets to baseline recent Crossgen2 bugs Apr 14, 2020
@trylek trylek requested a review from nattress April 14, 2020 16:05
I have removed the BinderTracingTest.Basic exclusion as Simon
already has a PR out to fix this particular bug. I have also
expanded the timeout from 150 to 200 minutes as my several
recent attempts to run the runtime-coreclr crossgen2 pipeline
timed out on Windows.

Thanks

Tomas
Copy link
Contributor

@nattress nattress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for baselining these regressions

@trylek trylek merged commit f99a103 into dotnet:master Apr 14, 2020
@trylek trylek deleted the MarkNewCG2Issues branch April 14, 2020 22:17
@janvorli
Copy link
Member

@trylek the rejit and eventpipe failures are not crossgen2 specific, there is a PR for fixing it: #34919

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants