Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to build of runtime's dependence on GetModuleIndex #34930

Closed
wants to merge 4 commits into from
Closed

Improvements to build of runtime's dependence on GetModuleIndex #34930

wants to merge 4 commits into from

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Apr 14, 2020

  • Whenever root scripts are used with clr.runtime, imply clr.buildtools should also be built.
  • Improve diagnostics of missing tools, useful in case people use build-runtime scripts directly.

Fixes #34894
Fixes #34920

@hoyosjs hoyosjs added this to the 5.0 milestone Apr 14, 2020
@hoyosjs hoyosjs self-assigned this Apr 14, 2020
mikem8361
mikem8361 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@mikem8361 mikem8361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and cleaning up the rough edges of my changes.

@jaredpar jaredpar mentioned this pull request Apr 14, 2020
Closed
@hoyosjs
Copy link
Member Author

hoyosjs commented Apr 15, 2020

Superseded by #34997

@hoyosjs hoyosjs closed this Apr 15, 2020
@jkotas jkotas deleted the juhoyosa/improve-clrbuildtools-exp branch April 17, 2020 04:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@mikem8361 mikem8361 mikem8361 approved these changes

Assignees

@hoyosjs hoyosjs

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0.0
3 participants
@hoyosjs @jkoritzinsky @mikem8361