[wasm][debugger] Show signature for delegate, or target, if available… #34933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
alexischr,
CoffeeFlux,
lambdageek,
lewurm,
SamMonoRT and
vargaz
as code owners
|
Tagging subscribers to this area: @thaystg |
monojenkins
force-pushed
the
sync-pr-19535-from-mono
branch
2 times, most recently
from
aa4ffa6
to
34508f1
Compare
monojenkins
force-pushed
the
sync-pr-19535-from-mono
branch
from
34508f1
to
f7bfeda
Compare
… (dotnet#19505) * [wasm][debugger] Show signature for delegate, or target, if available - As object properties, we return a `Target` which has the signature of the delegate target. Fixes mono/mono#19382 * [wasm][debugger] Some tidying up * [wasm][debugger] Remove unused `sig_desc` * [wasm][debugger] Simplify code, avoid extra allocations .. as suggested by @lewing (cherry picked from commit 4eca12e794764da1a0646e77af5b8c60a2e2767a)
monojenkins
force-pushed
the
sync-pr-19535-from-mono
branch
from
f7bfeda
to
3315091
Compare
|
This appears to be failing because of #35074 |
lewing
approved these changes
Apr 17, 2020
This was referenced Apr 17, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of mono/mono#19535, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
… (#19505)
Targetwhich has the signature ofthe delegate target.
Fixes mono/mono#19382
[wasm][debugger] Some tidying up
[wasm][debugger] Remove unused
sig_desc[wasm][debugger] Simplify code, avoid extra allocations
.. as suggested by @lewing
(cherry picked from commit 4eca12e794764da1a0646e77af5b8c60a2e2767a)