HttpClientMiniStressTest: Disable parallelism #34941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's possible for 4 different instances of SingleClient_ManyGets_Sync to run in parallel, each using up to 2 x 5000 sockets, totaling in 40,000 sockets. way beyond the original intent of testing 5000 client instances. since this additional stress is random in nature, I believe it is not intentional. This change make sure that those tests will not run in parallel, this avoids some issues I've encountered in some systems.
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
approved these changes
Apr 14, 2020
|
I'm checking if I can use this attribute on the base class, please don't merge yet. |
…te on the base class
|
Great, it's now a single line change, thanks for the quick feedback! |
stephentoub
approved these changes
Apr 14, 2020
Thanks, but I don't think it's necessary. These tests don't run in CI, and are only manually-enabled via an environment variable. They're really only intended for use when doing active development for things like performance to help minimize the chances of concurrency bugs sneaking in. |
davidsh
approved these changes
Apr 14, 2020
TalAloni
deleted the
TalAloni-HttpClientMiniStressTest-DisableParallelism-1
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's possible for 4 different instances of SingleClient_ManyGets_Sync to run in parallel, each using up to 2 x 5000 sockets, totaling in 40,000 sockets. way beyond the original intent of testing 5000 client instances. since this additional stress is random in nature, I believe it is not intentional.
This change prevents those tests from running in parallel, this avoids some issues I've encountered in some systems.