Remove outdated CoreFx.Private.TestUtilities.Unicode references #34981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
reviewed
Apr 15, 2020
safern
approved these changes
Apr 15, 2020
|
FYI: @cshung |
|
@safern Per your comment at #34981 (comment) I checked System.Runtime.sln and didn't see a reference at all to the NLS test project. So the most recent commit in this PR adds it. |
GrabYourPitchforks
added
area-Infrastructure
and removed
area-System.Globalization
labels
|
Tagging subscribers to this area: @ViktorHofer |
safern
approved these changes
Apr 15, 2020
|
Hello @safern! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ViktorHofer
approved these changes
Apr 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There remained some stray references after a recent refactoring.
I also updated the solution file to make the newly added System.Globalization.Nls.Tests project depend on the src project, just like the old System.Globalization.Tests project does.