Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and lint ECMA-335 Augments spec #35095

Merged
merged 13 commits into from
Apr 17, 2020
Merged

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Apr 17, 2020

Followup from dotnet/csharplang#2608 (comment):

Yes, I think it would be fine to start a ECMA-335 Augments doc where we will collect additions to ECMA-335 we would like to do, but do not have a good way to do currently. We have number of those.

Actually, we have a doc like already: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Reflection.Metadata/specs/Ecma-335-Issues.md . We should build on top of it. Rename it ...Augments, and maybe move this whole directory to a more discoverable place, e.g. docs\design\specs.

Once this PR is merged, I will start a PR to add a new section. The new section will need to be considered an official runtime specification and vetted by the runtime team. (See dotnet/roslyn#43281 (comment).)

There are 11 remaining markdownlint warnings. Any or all of the linting commits can be dropped, just ask.

/cc @jkotas

@jkotas
Copy link
Member

jkotas commented Apr 17, 2020

@jkotas
Copy link
Member

jkotas commented Apr 17, 2020

@jnm2
Copy link
Contributor Author

jnm2 commented Apr 17, 2020

@jkotas Thanks for the help. All addressed!

@jkotas jkotas merged commit da94c02 into dotnet:master Apr 17, 2020
@jkotas
Copy link
Member

jkotas commented Apr 17, 2020

Thank you!

@jnm2 jnm2 deleted the ecma_335_augments branch April 17, 2020 16:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants