-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move and lint ECMA-335 Augments spec #35095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Apr 17, 2020
I would move all docs from https://github.com/dotnet/runtime/blob/master/src/libraries/System.Reflection.Metadata/specs/ to this directory |
jkotas
reviewed
Apr 17, 2020
Add a link to this doc from https://github.com/dotnet/runtime/blob/master/docs/project/dotnet-standards.md#ecma-335---cli ? |
@jkotas Thanks for the help. All addressed! |
jkotas
approved these changes
Apr 17, 2020
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from dotnet/csharplang#2608 (comment):
Once this PR is merged, I will start a PR to add a new section. The new section will need to be considered an official runtime specification and vetted by the runtime team. (See dotnet/roslyn#43281 (comment).)
There are 11 remaining markdownlint warnings. Any or all of the linting commits can be dropped, just ask.
/cc @jkotas