Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VS minimum dependency #35114

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Update VS minimum dependency #35114

merged 1 commit into from
Apr 17, 2020

Conversation

ViktorHofer
Copy link
Member

With the net5.0 TFM change and the nuget static graph restore, we require VS >= 16.6 Preview2.

cc @danmosemsft @jaredpar

@ViktorHofer
Update VS minimum dependency
0a68713 
With the net5.0 TFM change and the nuget static graph restore, we require VS >= 16.6 Preview2.
@ViktorHofer ViktorHofer requested a review from a team April 17, 2020 15:55
@ghost
Copy link

ghost commented Apr 17, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer ViktorHofer mentioned this pull request Apr 17, 2020
Closed
@ViktorHofer ViktorHofer merged commit 3b42a9a into master Apr 17, 2020
@ViktorHofer ViktorHofer deleted the ViktorHofer-vsversion branch April 17, 2020 18:00
@sdmaclea
Copy link
Contributor

sdmaclea commented Apr 30, 2020 •
edited
Loading

@ViktorHofer This wasn't in the developer workflow changes announcement.
I am also not sure why it wasn't properly staged.

@ViktorHofer
Copy link
Member Author

@sdmaclea the SDK upgrade was announced in #33821. This PR only updated the documentation which was missed.

@sdmaclea
Copy link
Contributor

sdmaclea commented Apr 30, 2020 •
edited
Loading

I don't see it in that announcement. Is it buried in the details somewhere?

I see "Minimum sdk version will be upgraded", but no mention of a minimum VS version.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 30, 2020 •
edited
Loading

First item for the SDK:

Minimum sdk version will be upgraded, install from https://github.com/dotnet/installer#installers-and-binaries.

And just noticed that the VS update was only announced via mail. Re-sent it to you.

@sdmaclea
Copy link
Contributor

Thanks.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anipik Anipik Anipik approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ViktorHofer @sdmaclea @Anipik @safern @Dotnet-GitSync-Bot