Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stack overflow stack trace reporting on OSX #35418

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Apr 24, 2020

When the stack overflow stack trace logging to console was enabled recently,
it was not done for OSX. This change rectifies it.

Close #35402

When the stack overflow stack trace logging to console was enabled recently,
it was not done for OSX. This change rectifies it.
@janvorli janvorli added this to the 5.0 milestone Apr 24, 2020
@janvorli janvorli requested a review from jkotas April 24, 2020 18:31
@janvorli janvorli self-assigned this Apr 24, 2020
@danmoseley
Copy link
Member

Are tests feasible for SO handling (on all platforms)? I'm thinking a CLR style test that diffs the console output. It would be a shame if this valuable feature regressed.

@janvorli
Copy link
Member Author

Are tests feasible for SO handling (on all platforms)? I'm thinking a CLR style test that diffs the console output.

I have an issue for adding tests for this: #32203. The output of the stack overflow log will vary between different platforms and possibly even between different builds based on how much stack space is consumed by the native runtime code on the stack bottom or in the middle of the stack and how much total stack space is there on a given platform. But it seems that the output could be parsed to determine whether it makes sense or not.

@janvorli
Copy link
Member Author

Btw, when testing this PR, I've found there is an issue with the stack overflow stack trace reporting that needs to be fixed: #35420

@danmoseley
Copy link
Member

But it seems that the output could be parsed to determine whether it makes sense or not.

Right, I figured it could simply verify that there was at least one line of stack - eg., just grep for the source file name.

@janvorli janvorli closed this Apr 27, 2020
@janvorli janvorli reopened this Apr 27, 2020
@janvorli janvorli merged commit d307659 into dotnet:master Apr 28, 2020
@janvorli janvorli deleted the fix-stack-overflow-reporting-osx branch April 28, 2020 16:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack trace on stack overflow is not displayed on macOS
3 participants