Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spannified internals of BigInteger #35565

Merged
merged 99 commits into from
Oct 8, 2021
Merged

Spannified internals of BigInteger #35565

merged 99 commits into from
Oct 8, 2021

Commits on Apr 27, 2020

  1. Unsafe pointers replaced with managed pointers

    @sakno
    sakno committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    51260fd View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Duplicate code replaced with static local

    @sakno
    sakno committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    27cd3b6 View commit details
    Browse the repository at this point in the history

  2. Spannified internals

    @sakno
    sakno committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    f6d1f89 View commit details
    Browse the repository at this point in the history

  3. Spannified compare

    @sakno
    sakno committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d8af4fd View commit details
    Browse the repository at this point in the history

  4. Spannified div/rem operations

    @sakno
    sakno committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    ca1cf5c View commit details
    Browse the repository at this point in the history

  5. Minus two array allocations for each bitwise operation

    @sakno
    sakno committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d89cdea View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Removed redundant locals

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    7a6a0d8 View commit details
    Browse the repository at this point in the history

  2. Sync with upstream

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    eb64ad1 View commit details
    Browse the repository at this point in the history

  3. Code review feedback (code style)

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ba2a01e View commit details
    Browse the repository at this point in the history

  4. Code review feedback

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    49317c5 View commit details
    Browse the repository at this point in the history

  5. LeadingZeroes replaced with BitOperations

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    fa47aea View commit details
    Browse the repository at this point in the history

  6. stackalloc in Divide without remainder

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ea7c29b View commit details
    Browse the repository at this point in the history

  7. Reduced memory allocation for bitwise operations

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    a1e5006 View commit details
    Browse the repository at this point in the history

  8. Managed pointer replaced with Span

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    f19ff53 View commit details
    Browse the repository at this point in the history

  9. Removed namespace imports

    @sakno
    sakno committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    6e8705f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Removed delegate type

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    34893a3 View commit details
    Browse the repository at this point in the history

  2. Reduced memory allocation in the end of each bitwise operation

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    5992406 View commit details
    Browse the repository at this point in the history

  3. Code review feedback

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    2b7b7ba View commit details
    Browse the repository at this point in the history

  4. Removed redundant array allocation

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    03313c1 View commit details
    Browse the repository at this point in the history

  5. Trivial division moved to stack alloc

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    92618a4 View commit details
    Browse the repository at this point in the history

  6. Reduced memory allocation for divide operator

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    65f2701 View commit details
    Browse the repository at this point in the history

  7. Reduced memory allocation for shift operations

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    b5a77b4 View commit details
    Browse the repository at this point in the history

  8. Array pooling for Square operation

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ea35011 View commit details
    Browse the repository at this point in the history

  9. Fixed bound check for bitwise operations

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    9da2cb3 View commit details
    Browse the repository at this point in the history

  10. Multiply now uses array pooling

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    ed6d159 View commit details
    Browse the repository at this point in the history

  11. Removed namespace import

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    e53dc14 View commit details
    Browse the repository at this point in the history

  12. Reduced memory allocation for Add

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    6d84785 View commit details
    Browse the repository at this point in the history

  13. Removed swap of arguments

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    a4482e0 View commit details
    Browse the repository at this point in the history

  14. Reduced memory allocations for multiply operator

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    b0752ea View commit details
    Browse the repository at this point in the history

  15. Reduced memory allocations for modulo operator

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    8c9cfdc View commit details
    Browse the repository at this point in the history

  16. Temporarily spannify ActualLength method

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    15b4eef View commit details
    Browse the repository at this point in the history

  17. Spannify FastReducer

    @sakno
    sakno committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    fb263bf View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Spannify initial parts of GCD alg

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    f71442d View commit details
    Browse the repository at this point in the history

  2. Simple GCD test for debugging

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    156b7ac View commit details
    Browse the repository at this point in the history

  3. Simple test for debugging

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    036c535 View commit details
    Browse the repository at this point in the history

  4. Removed debug code

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    7fa1438 View commit details
    Browse the repository at this point in the history

  5. Spannified GCD algorithm

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    a4c4891 View commit details
    Browse the repository at this point in the history

  6. Removed arg passing by ref

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    900ac48 View commit details
    Browse the repository at this point in the history

  7. Complete migration of gcd to span

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    3a5a117 View commit details
    Browse the repository at this point in the history

  8. Removed memory allocation for trivial case of GCD

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    97ee31b View commit details
    Browse the repository at this point in the history

  9. Reorganize utility code

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    4e6a403 View commit details
    Browse the repository at this point in the history

  10. Removed redundant parameter

    @sakno
    sakno committed May 1, 2020
    Configuration menu
    Copy the full SHA
    dd69148 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2020

  1. Reduced memory alloc for trivial case of Pow alg

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    1f84dc7 View commit details
    Browse the repository at this point in the history

  2. Use span for trivial modulus pow case

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    875cd16 View commit details
    Browse the repository at this point in the history

  3. Use span for trivial cases of pow modulus

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    19086a6 View commit details
    Browse the repository at this point in the history

  4. Fixed buffer cleanup

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    64597dc View commit details
    Browse the repository at this point in the history

  5. Reduced memory allocation of ModPow operations

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    f86c616 View commit details
    Browse the repository at this point in the history

  6. BitsBuffer replaced with span

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    7509c59 View commit details
    Browse the repository at this point in the history

  7. Reorganize utility methods

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    61e028b View commit details
    Browse the repository at this point in the history

  8. Reduced visibility scope

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    4ff0bd5 View commit details
    Browse the repository at this point in the history

  9. Removed temporary code for bits cleanup

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    9e2242e View commit details
    Browse the repository at this point in the history

  10. Fill leading bits with zeroes

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    98b7fa8 View commit details
    Browse the repository at this point in the history

  11. Unify order of parameters

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    f5a5b9e View commit details
    Browse the repository at this point in the history

  12. Unify order of parameters

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    f713703 View commit details
    Browse the repository at this point in the history

  13. Unify order of parameters

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    0f1f935 View commit details
    Browse the repository at this point in the history

  14. Reuse the same local var

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    c9ba177 View commit details
    Browse the repository at this point in the history

  15. Sync with master

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    1b12fde View commit details
    Browse the repository at this point in the history

  16. Removed whtespace

    @sakno
    sakno committed May 2, 2020
    Configuration menu
    Copy the full SHA
    e1afe77 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2020

  1. Code review feedback

    @sakno
    sakno committed May 3, 2020
    Configuration menu
    Copy the full SHA
    f085cc4 View commit details
    Browse the repository at this point in the history

  2. Avoid misleading with Span.CopyTo

    @sakno
    sakno committed May 3, 2020
    Configuration menu
    Copy the full SHA
    30132f0 View commit details
    Browse the repository at this point in the history

  3. Clarify purpose of slicing 

    Co-authored-by: Günther Foidl <gue@korporal.at>
    @sakno @gfoidl
    sakno and gfoidl authored May 3, 2020
    Configuration menu
    Copy the full SHA
    0344cb2 View commit details
    Browse the repository at this point in the history

  4. Replace mentioning of uint[] in comments

    @sakno
    sakno committed May 3, 2020
    Configuration menu
    Copy the full SHA
    4c6dd0b View commit details
    Browse the repository at this point in the history

  5. Fixed code formatting issues

    @sakno
    sakno committed May 3, 2020
    Configuration menu
    Copy the full SHA
    35bd53c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Merge with master

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    b7b3460 View commit details
    Browse the repository at this point in the history

  2. Share StackAllocThreshold const

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    9f498b0 View commit details
    Browse the repository at this point in the history

  3. Ignore const threshold values in Release config

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    7bc63c8 View commit details
    Browse the repository at this point in the history

  4. Literal field cannot be discovered with TypeInfo.GetDeclaredField

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    dd7bdef View commit details
    Browse the repository at this point in the history

  5. Removed invalid assertion

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    fe53099 View commit details
    Browse the repository at this point in the history

  6. Removed invalid assertion

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    55d949f View commit details
    Browse the repository at this point in the history

  7. Removed invalid assertion

    @sakno
    sakno committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    61d470d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Sync with upstream

    @sakno
    sakno committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    8a7ba77 View commit details
    Browse the repository at this point in the history

  2. Code review feedback

    @sakno
    sakno committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    808c12c View commit details
    Browse the repository at this point in the history

  3. Fixed header

    @sakno
    sakno committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7db731c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Sync with upstream

    @sakno
    sakno committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    8762259 View commit details
    Browse the repository at this point in the history

  2. Fixed overflow of result buffer

    @sakno
    sakno committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    24d2ff4 View commit details
    Browse the repository at this point in the history

  3. Reduced ctor visibility

    @sakno
    sakno committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    60777dd View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Eliminated bounds check

    @sakno
    sakno committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    fa5eb5e View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Returned optimization using Math.DivRem

    @sakno
    sakno committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    ec1285d View commit details
    Browse the repository at this point in the history

  2. Added braces to be consistent with other branches

    @sakno
    sakno committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    f01d089 View commit details
    Browse the repository at this point in the history

  3. Fixed location of the comment

    @sakno
    sakno committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    484d6ff View commit details
    Browse the repository at this point in the history

  4. Combine slice and conversion as the single line

    @sakno
    sakno committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    e1161f0 View commit details
    Browse the repository at this point in the history

  5. Combine slice and conversion as the single line

    @sakno
    sakno committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9855da5 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Sync with upstream

    @sakno
    sakno committed May 10, 2021
    Configuration menu
    Copy the full SHA
    9a22a4e View commit details
    Browse the repository at this point in the history

  2. Merge with parsing optimizations

    @sakno
    sakno committed May 10, 2021
    Configuration menu
    Copy the full SHA
    eeb2cdd View commit details
    Browse the repository at this point in the history

  3. Reduced checks

    @sakno
    sakno committed May 10, 2021
    Configuration menu
    Copy the full SHA
    1b30bb0 View commit details
    Browse the repository at this point in the history

  4. Removed redundant global const

    @sakno
    sakno committed May 10, 2021
    Configuration menu
    Copy the full SHA
    fb514a1 View commit details
    Browse the repository at this point in the history

  5. Replaced magic consts with their named equivalents

    @sakno
    sakno committed May 10, 2021
    Configuration menu
    Copy the full SHA
    b4ac5e5 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Removed useless asserts

    @sakno
    sakno committed May 12, 2021
    Configuration menu
    Copy the full SHA
    932eef3 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Merge branch 'main' into issue-22609

    @sakno
    sakno committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    fd0124a View commit details
    Browse the repository at this point in the history

  2. Manual merge with dotnet#53984 PR

    @sakno
    sakno committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    a4f3f22 View commit details
    Browse the repository at this point in the history

  3. Review feedback (use const for stackalloc)

    @sakno
    sakno committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    2a94300 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Merge branch 'main' and dotnet#57297

    @sakno
    sakno committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    82187cb View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Sync with upstream

    @sakno
    sakno committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    1a9cf2b View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @sakno
    sakno committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    4971224 View commit details
    Browse the repository at this point in the history

  3. Unsafe code replaced with span indexer where possible

    @sakno
    sakno committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    020e749 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Removed unused local

    @sakno
    sakno committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    68306d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Sync with upstream

    @sakno
    sakno committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    65485fa View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Sync with upstream

    @sakno
    sakno committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    fe39909 View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @sakno
    sakno committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    602574f View commit details
    Browse the repository at this point in the history