Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64: Add TBL and TBX emitter tests and make displayer always emit 16B. #35707

Merged
merged 1 commit into from
May 1, 2020
Merged

Arm64: Add TBL and TBX emitter tests and make displayer always emit 16B. #35707

merged 1 commit into from
May 1, 2020

Conversation

TamarChristinaArm
Copy link
Contributor

Hi All,

This adds the missing emitter tests from #35600.

Also removed an unused variable and make the display always use 16B per the specification of TBL and TBX.

/CC @echesakovMSFT @tannergooding @CarolEidt

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 1, 2020
echesakov
echesakov approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@echesakov echesakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@echesakov echesakov merged commit f8f18f0 into dotnet:master May 1, 2020
@jaredpar jaredpar mentioned this pull request May 5, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@echesakov echesakov echesakov approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TamarChristinaArm @echesakov @tannergooding @Dotnet-GitSync-Bot