-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase FailingTestTimeoutMiliseconds for Ssl server tests. #36101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Net.Security
test-enhancement
Improvements of test source code
labels
May 8, 2020
Tagging subscribers to this area: @dotnet/ncl |
I also updated the ITestOutputHelper so we get
instead of
and the output is written to testResults.xml so we can retrieve from Azure Pipeline as well. |
stephentoub
reviewed
May 8, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestConfiguration.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
May 8, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestConfiguration.cs
Show resolved
Hide resolved
safern
reviewed
May 8, 2020
src/libraries/System.Net.Security/src/System/Net/Security/TlsFrameHelper.cs
Show resolved
Hide resolved
It would be nice to get this in today since it is reproing in PRs and Rolling builds. |
stephentoub
approved these changes
May 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Dec 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at recent failure of ServerAsyncAuthenticate_MismatchProtocols_Fails I noticed that the test failed with timeout after ~1s. With the expectation of TLS alert, we need to receive Hello, process it, send response, read it from socket, give it to OS and then throw.
All the failures were on debug builds and existing 250ms seems pretty short.
I could not reproduce the failure locally and proposed 3s is just a guess for upper limit.
(test will finish faster if expected failure happen faster)
The value is only used by ServerAsyncSslHelper() and tests using it.
fixes #29642 (another attempt)