Fixing test failing on arm64 #36145
Merged
Fixing test failing on arm64 #36145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: I've manually triggered a rolling build from my PR to ensure the tests run on arm64 and pass. https://dev.azure.com/dnceng/public/_build/results?buildId=637410&view=results |
safern
approved these changes
May 8, 2020
src/libraries/System.DirectoryServices.Protocols/tests/BerConverterTests.cs
Show resolved
Hide resolved
bartonjs
approved these changes
May 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36087
The test was sending the wrong object which made it behave differently on arm64 and x64 archs. This fix will now send a valid payload that matches the format, which could now be converted and should have the same expected values across OSes and platforms.
cc: @bartonjs