-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passed cancellationToken might be default. #37441
Conversation
Tagging subscribers to this area: @dotnet/ncl |
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
BTW, does the test still make sense if we're bypassing the passed in cancellationToken? |
The test is named "PostAsync_Cancel_CancellationTokenPassedToContent"... if the cancellation token isn't passed to the content with WinHttpHandler, then we probably should just skip the test on WinHttpHandler ;) |
67ce02e
to
85cdfdb
Compare
/azp run runtime-libraries outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Test skipped on |
In cases like WinHttpHandler (which is also build against .NET Framework), there is no way how to properly pass cancellationToken to content's
CopyToAsync
. The overloads accepting it are recent addition and not part of .NET Standard.The tests were deadlocking waiting for
cts.Task
which is supposed to be finished fromcancellationToken.Register(...)
on the token that is not bound to test'sTaskCompletionSource
.Fixes #36689
cc: @stephentoub