Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WinRT specific code from EventSource. #37508

Merged
2 commits merged into from
Jun 6, 2020

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jun 5, 2020

Since we no longer have WinRT specific code in the runtime, we don't need these build defines in the EventSource code. No one is setting these defines, and it is confusing when looking at the code what types are public and what aren't.

Follow up to #36715

cc @brianrob

@ghost
Copy link

ghost commented Jun 5, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented Jun 5, 2020

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
Notify danmosemsft if you want to be subscribed.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brianrob
Copy link
Member

brianrob commented Jun 5, 2020

You will also want to get rid of the GetMetadata method and all references to it: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs#L712.

It was added to provide a mechanism for EventSource to fetch metadata that was produced as part of the build.

@ghost
Copy link

ghost commented Jun 6, 2020

Hello @eerhardt!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit aa4d705 into dotnet:master Jun 6, 2020
@eerhardt eerhardt deleted the RemoveEventSourcePN branch June 6, 2020 15:07
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants