Skip Bundle_can_be_renamed() installer test #38014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar |
ViktorHofer
approved these changes
Jun 17, 2020
|
Hello @swaroop-sridhar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
stephentoub
reviewed
Jun 17, 2020
| @@ -22,7 +22,7 @@ public BundleRename(SharedTestState fixture) | |||
| sharedTestState = fixture; | |||
| } | |||
|
|
|||
| [Theory] | |||
| [Theory(Skip = "Fails in CI: https://github.com/dotnet/runtime/issues/35068")] | |||
There was a problem hiding this comment.
We use [ActiveIssue(...)] for such things in the library tests. I've not paid attention in the past to what's used in the installer tests. Are we able to use [ActiveIssue(...)] in such cases as well? If we haven't before, don't worry about it for this PR; in the future, it'd be nice to align across all the tests in the repo.
There was a problem hiding this comment.
ActiveIssue should work fine as well in installer.
stephentoub
approved these changes
Jun 17, 2020
This test is randomly failing in the lab: dotnet#35068 Therefore skip this test until the underlying problem is resolved. Enabling the test is tracked by dotnet#38013 Fixes dotnet#35068.
swaroop-sridhar
force-pushed
the
skiprename
branch
from
caecad8
to
0f83ffb
Compare
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is randomly failing in the lab: #35068
Therefore skip this test until the underlying problem is resolved.
Enabling the test is tracked by #38013
Fixes #35068.