Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase delays in flaky tests #38444

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Increase delays in flaky tests #38444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,7 +2271,7 @@ public async Task PostAsyncDuplex_CancelledBeforeResponseHeadersReceived_ResetsS
cancellationTokenSource.Cancel();

// Cancellation may not propagate immediately. So wait a brief time to try to ensure it propagates.
await Task.Delay(500);
await Task.Delay(3000);

// Attempting to write on the request body should now fail with OperationCanceledException.
Exception e = await Assert.ThrowsAnyAsync<OperationCanceledException>(async () => { await SendAndReceiveRequestDataAsync(contentBytes, requestStream, connection, streamId); });
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ await server.AcceptConnectionAsync(async connection =>

// Wait a small amount of time before sending the first response, so the connection lifetime will expire.
Debug.Assert(lifetimeMilliseconds < 100);
await Task.Delay(100);
await Task.Delay(1000);

// Second request should not have completed yet, as we haven't completed the first yet.
Assert.False(request2.IsCompleted);
Expand Down