-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add X64/Arm64 nested classes to System.Runtime.Intrinsics where missing #38460
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
CC. @echesakovMSFT, @CarolEidt for review. CC. @EgorBo, this seems to have broken Mono, is there something specific I need to update? |
@tannergooding looks like it's a different issue, so should be OK from mono side. |
Alright, it looked to be a failure in the test this PR is adding, so I wasn't sure. Thanks! |
@EgorBo, looks like its still failing. Based on the failure, some API is returning |
@tannergooding where can I find that test? I don't see any |
Right here: https://github.com/dotnet/runtime/pull/38460/files#diff-e4e58d0c6a832040d081a159b95e83bb It just validates that for any |
can you please add this test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was JIT/EE interface breaking change and it should have updated the JIT/EE interface GUID. I am adding a note about it in #39777 |
This resolves #34587 by adding in X64 and Arm64 nested classes to the System.Runtime.Intriniscs classes where they were missing.