-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interpreter build #38673
Fix interpreter build #38673
Conversation
@dotnet/jit-contrib Can someone take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Whoops, had meant to approve, but looks like I forgot to hit the submit button. thanks, @AndyAyersMS & @BruceForstall. @yuchong-pan, I think this change removes the attempts at scoping |
Correct. The problem is it broke the Release builds. I didn't look to see if there was an equivalent functionality that would work in Release builds, or we should just find a "production quality" implementation as previously described. |
Fix the x86, arm32, and arm64 builds, and the Release builds.