Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpreter build #38673

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Conversation

BruceForstall
Copy link
Member

@BruceForstall BruceForstall commented Jul 1, 2020

Fix the x86, arm32, and arm64 builds, and the Release builds.

@ghost
Copy link

ghost commented Jul 1, 2020

Tagging subscribers to this area: @BrzVlad, @lewurm
Notify danmosemsft if you want to be subscribed.

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib Can someone take a look?

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 937f6e5 into dotnet:master Jul 2, 2020
@BruceForstall BruceForstall deleted the FixInterpreterBuild branch July 2, 2020 02:15
@josalem
Copy link
Contributor

josalem commented Jul 2, 2020

Whoops, had meant to approve, but looks like I forgot to hit the submit button. thanks, @AndyAyersMS & @BruceForstall. @yuchong-pan, I think this change removes the attempts at scoping get_IsSupported to just HW intrinsic classes for Checked/Release builds of the runtime. Effectively, this will now return false for any method named get_IsSupported inside SPCL. In fact, I think this might have already been the behavior since GetDebugClassName only works under DEBUG builds to begin with. This isn't necessarily an issue right now, just something to consider when we go to make a production quality version of HW intrinsics for the interpreter 😄.

@BruceForstall
Copy link
Member Author

I think this change removes the attempts at scoping get_IsSupported to just HW intrinsic classes for Checked/Release builds of the runtime.

Correct. The problem is it broke the Release builds. I didn't look to see if there was an equivalent functionality that would work in Release builds, or we should just find a "production quality" implementation as previously described.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants