Annotate and adjust more of CoreLib for trimming #38865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
vitek-karas
approved these changes
Jul 7, 2020
src/mono/netcore/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs
Outdated
Show resolved
Hide resolved
src/mono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/TypeBuilder.Mono.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 7, 2020
| public virtual Type GetDefaultWriter() | ||
| { | ||
| Assembly resourceWriterAssembly = Assembly.Load("System.Resources.Writer, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"); | ||
| return resourceWriterAssembly.GetType("System.Resources.ResourceWriter", throwOnError: true)!; | ||
| return Type.GetType("System.Resources.ResourceWriter, System.Resources.Writer", throwOnError: true)!; |
There was a problem hiding this comment.
@jkotas split this into the 2 calls in https://github.com/dotnet/coreclr/pull/11314/files#diff-37ee6a4a589ffae33ce341f9c1a28133R136. Are we sure this is safe to collapse it back into a single Type.GetType call?
There was a problem hiding this comment.
The PR was reconciling differences between multiple forked copies of the same code. I do not think there was a strong reason why I have changed this to Assembly.Load + GetType that was used in the other fork.
It should be ok to change it back to Type.GetType.
stephentoub
approved these changes
Jul 9, 2020
|
Failures are #39484 |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Annotate and adjust more of CoreLib for trimming * Update CustomAttribute.cs * Update TypeBuilder.Mono.cs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.