Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak BufferPtrSendOperation to address argument confusion #38868

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Tweak BufferPtrSendOperation to address argument confusion #38868

merged 1 commit into from
Jul 7, 2020

Conversation

stephentoub
Copy link
Member

Addresses the suggestion in #38762 (comment)
cc: @GrabYourPitchforks, @adamsitnik

@ghost
Copy link

ghost commented Jul 7, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

adamsitnik
adamsitnik approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub thank you!

@adamsitnik adamsitnik merged commit c5e6221 into dotnet:master Jul 7, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@stephentoub stephentoub deleted the argumentconfusion branch October 12, 2020 00:27
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-System.Net.Sockets
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@stephentoub @adamsitnik @wfurt @karelz @Dotnet-GitSync-Bot