Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SqlState and IsTransient to DbException #39157

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

roji
Copy link
Member

@roji roji commented Jul 12, 2020

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 12, 2020

Tagging subscribers to this area: @roji, @ajcvickers
Notify danmosemsft if you want to be subscribed.

@roji
Copy link
Member Author

roji commented Jul 12, 2020

Note: I still plan to look into a default implementation of IsTransient which recognizes certain standard values in SqlState - but am leaving that for later.

@roji roji merged commit 1b8d1dc into dotnet:master Jul 12, 2020
@roji roji deleted the DbExceptionApis branch July 12, 2020 21:20
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants