Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liveness of FrameListRoot #39452

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Fix liveness of FrameListRoot #39452

merged 3 commits into from
Jul 17, 2020

Conversation

CarolEidt
Copy link
Contributor

The FrameListRoot variable isn't used if call->IsSuppressGCTransition(), but liveness wasn't checking this.

Fix #39221

@CarolEidt
Fix liveness of FrameListRoot
269bb3f 
The FrameListRoot variable isn't used if `call->IsSuppressGCTransition()`, but liveness wasn't checking this.

Fix dotnet#39221
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 16, 2020
@CarolEidt
Copy link
Contributor Author

This issue was introduced with dotnet/coreclr#26458 but apparently went unnoticed for some time.

jkotas
jkotas reviewed Jul 16, 2020
View reviewed changes
src/coreclr/src/jit/liveness.cpp Outdated
@@ -1904,8 +1903,9 @@ void Compiler::fgComputeLifeLIR(VARSET_TP& life, BasicBlock* block, VARSET_VALAR
// Removing a call does not affect liveness unless it is a tail call in a nethod with P/Invokes or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Removing a call does not affect liveness unless it is a tail call in a nethod with P/Invokes or
// Removing a call does not affect liveness unless it is a tail call in a method with P/Invokes or

@CarolEidt
Copy link
Contributor Author

@dotnet/jit-contrib @AaronRobinsonMSFT PTAL

@CarolEidt
Copy link
Contributor Author

ping @dotnet/jit-contrib

@jaredpar jaredpar mentioned this pull request Jul 17, 2020
Closed
@CarolEidt
Copy link
Contributor Author

@dotnet/dnceng - The Build OSX x64 release Runtime_Debug leg has not completed, but doesn't allow me to retry. What is the way to deal with this?

@MattGal
Copy link
Member

MattGal commented Jul 17, 2020

@dotnet/dnceng - The Build OSX x64 release Runtime_Debug leg has not completed, but doesn't allow me to retry. What is the way to deal with this?

new to me, checking it out.

@MattGal
Copy link
Member

MattGal commented Jul 17, 2020

@CarolEidt looks like a new failure mode for Github / AzDO integration. The reason you can't restart it is that it did finish, yesterday evening : https://dev.azure.com/dnceng/public/_build/results?buildId=734471&view=logs&j=9db4066d-6bf0-549a-7716-e181239d2ea7&s=d654deb9-056d-50a2-1717-90c08683d50a on attempt 2.

This is a repo that doesn't block on passing CI, and it did actually pass, so assuming you get signoff you can just merge. I'll share this incident with the lead for this area to make sure it's on their radar.

@MattGal
Copy link
Member

MattGal commented Jul 17, 2020

Feel free to upvote this issue if you'd like this GitHub / AzDO integration issue to get more priority: https://developercommunity.visualstudio.com/content/problem/1117817/github-reporting-in-progress-azure-devops-build-th.html

@CarolEidt
Copy link
Contributor Author

ping again @dotnet/jit-contrib

@CarolEidt CarolEidt merged commit 49186d7 into dotnet:master Jul 17, 2020
@CarolEidt CarolEidt deleted the Fix39221 branch July 17, 2020 23:20
This was referenced Jul 27, 2020
Closed
Closed
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@CarolEidt @Jacksondr5
Fix liveness of FrameListRoot (dotnet#39452)
f81acaf 
* Fix liveness of FrameListRoot

The FrameListRoot variable isn't used if `call->IsSuppressGCTransition()`, but liveness wasn't checking this.

Fix dotnet#39221
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

LSRA assert when running PMI on xunit.performance.execution.dll
7 participants
@CarolEidt @MattGal @jkotas @BruceForstall @AaronRobinsonMSFT @karelz @Dotnet-GitSync-Bot