Narrow utf16 to ascii #39509
Closed
Narrow utf16 to ascii #39509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgovind
force-pushed
the
NarrowUtf16ToAscii
branch
from
506c3b7
to
e6621fa
Compare
pgovind
force-pushed
the
NarrowUtf16ToAscii
branch
from
3e8be4a
to
abc8ead
Compare
pgovind
added
area-System.Runtime.Intrinsics
and removed
NO-REVIEW
|
Tagging subscribers to this area: @tannergooding |
src/libraries/System.Utf8String.Experimental/src/System/Runtime/Intrinsics/Intrinsics.Shims.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 24, 2020
echesakov
reviewed
Jul 27, 2020
| } | ||
| else if (AdvSimd.Arm64.IsSupported) | ||
| { | ||
| if (ContainsNonAsciiValue(AdvSimd.AddSaturate(utf16VectorFirst.AsUInt16(), asciiMaskForAddSaturate))) |
There was a problem hiding this comment.
If I understand the original Sse2 algorithm right - this is testing if any of the characters in utf16VectorFirst is outside of [0, 0x7f] value range, right?
I don't think the algorithm on Arm64 should copy exactly, what Sse2 does.
I believe the following should be enough
AdvSimd.MaxPairwise(utf16VectorFirst.AsUInt16(), utf16VectorFirst.AsUInt16()).AsUInt64().ToScalar() & 0xFF80FF80FF80FF80UL != 0
| } | ||
| else if (AdvSimd.Arm64.IsSupported) | ||
| { | ||
| utf16VectorFirst = AdvSimd.LoadVector128((short*)pUtf16Buffer); |
There was a problem hiding this comment.
minor: add a comment // unaligned load
| } | ||
| else if (AdvSimd.Arm64.IsSupported) | ||
| { | ||
| if (ContainsNonAsciiValue(AdvSimd.AddSaturate(utf16VectorFirst.AsUInt16(), asciiMaskForAddSaturate))) |
pgovind
force-pushed
the
NarrowUtf16ToAscii
branch
from
abc8ead
to
fc338c0
Compare
2 tasks
|
@pgovind I'm going to close this PR since this work is on hold. When we get back around to this work, we can create a fresh PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review now.
NOTE: There is a bug here somewhere, but I can't seem to find it, so I'd appreciate another pair of eyes in this code. When I try to test this on WSL2, I get an error saying "Can't find file xunit.console.deps.json" when that file does in fact exist. The real error is that the xunit infra itself calls into the method being modified here and something goes wrong (maybe marshalling the path from
stringto native also uses this code? I'm not sure). AFAICT the changes are right.